From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: remove unused fields Date: Mon, 05 May 2014 18:05:43 +0200 Message-ID: <2016976.lP8QZ899V2@xps13> References: <1397825888-24399-1-git-send-email-david.marchand@6wind.com> <20140418132323.GF4053@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: David Marchand Return-path: In-Reply-To: <20140418132323.GF4053-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-04-18 09:23, Neil Horman: > On Fri, Apr 18, 2014 at 02:58:08PM +0200, David Marchand wrote: > > There is no need for a 'magic' field in struct rte_config, as this part of > > the structure is local to each process. All threads of a process are > > synchronised because of the run_once atomic. > > So remove this field, as it is only adding confusion when reading code > > that > > references 'magic' field from struct rte_mem_config. > > > > Besides, there is no reference about the 'version' field, so remove it as > > well. > > > > Signed-off-by: David Marchand > > Acked-by: Neil Horman Applied for version 1.7.0. -- Thomas