From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v4 1/2] net/vhost: create datagram sockets immediately Date: Wed, 4 Jan 2017 16:06:31 +0800 Message-ID: <20170104080631.GM21228@yliu-dev.sh.intel.com> References: <1483460563-5003-1-git-send-email-ciwillia@brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, mtetsuyah@gmail.com, stable@dpdk.org To: "Charles (Chas) Williams" Return-path: Content-Disposition: inline In-Reply-To: <1483460563-5003-1-git-send-email-ciwillia@brocade.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 03, 2017 at 11:22:42AM -0500, Charles (Chas) Williams wrote: > If you create a vhost server device, it doesn't create the actual datagram > socket until you call .dev_start(). If you call .dev_stop() is also > deletes those sockets. For QEMU clients, this is a problem since QEMU > doesn't know how to re-attach to datagram sockets that have gone away. > > To fix this, register and unregister the datagram sockets during device > creation and removal. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Both patches applied to dpdk-next-virtio. Thanks! Note that we prefer a title of "prefix: fix ..." for bug fixing patch. For this reason, I have changed the title for you while apply: net/vhost: fix socket file being deleted on dev stop Also, stable is cc'ed. --yliu