From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: add support for ConnectX-5 NICs Date: Thu, 5 Jan 2017 11:38:21 +0100 Message-ID: <20170105103821.GM12822@6wind.com> References: <20170105023219.10146-1-yskoh@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ferruh.yigit@intel.com, dev@dpdk.org To: Yongseok Koh Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id A46C02C36 for ; Thu, 5 Jan 2017 11:38:29 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id t79so479852247wmt.0 for ; Thu, 05 Jan 2017 02:38:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170105023219.10146-1-yskoh@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Koh, On Wed, Jan 04, 2017 at 06:32:19PM -0800, Yongseok Koh wrote: > Add PCI device ID for ConnectX-5 and enable multi-packet send for PF and > VF. > > Signed-off-by: Yongseok Koh > --- > > ConnectX-5 is a newly announced NIC of Mellanox. This patch includes basic > enablement of ConnectX-5. > > drivers/net/mlx5/mlx5.c | 42 +++++++++++++++++++++++++++++++++++++----- > drivers/net/mlx5/mlx5.h | 4 ++++ > drivers/net/mlx5/mlx5_ethdev.c | 7 ++----- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 4 files changed, 44 insertions(+), 11 deletions(-) [...] While the changes made by this patch are fine, it is missing the mandatory update of related documentation, specifically: - doc/guides/nics/mlx5.rst: places where ConnectX-4 is also mentioned must be updated. - doc/guides/rel_notes/release_17_02.rst: support for ConnectX-5 must appear somewhere (you can use past release notes as a template). -- Adrien Mazarguil 6WIND