From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 2/5] net/e1000: add firmware version get
Date: Sun, 8 Jan 2017 15:03:55 -0800
Message-ID: <20170108150355.3bce1403@xeon-e3>
References: <1483531428-14481-1-git-send-email-qiming.yang@intel.com>
 <1483848695-44643-1-git-send-email-qiming.yang@intel.com>
 <1483848695-44643-3-git-send-email-qiming.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,
 remy.horton@intel.com
To: Qiming Yang <qiming.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 0DEAF1E2B
 for <dev@dpdk.org>; Mon,  9 Jan 2017 00:04:03 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id y143so4861336pfb.0
 for <dev@dpdk.org>; Sun, 08 Jan 2017 15:04:03 -0800 (PST)
In-Reply-To: <1483848695-44643-3-git-send-email-qiming.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun,  8 Jan 2017 12:11:32 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

> +	switch (hw->mac.type) {
> +	case e1000_i210:
> +	case e1000_i211:
> +		if (!(e1000_get_flash_presence_i210(hw))) {
> +			snprintf(fw_version, fw_length,
> +				 "%2d.%2d-%d",
> +				 fw.invm_major, fw.invm_minor,
> +				 fw.invm_img_type);
> +			break;
> +		}
> +		/* fall through */
> +	default:
> +		/* if option rom is valid, display its version too*/
> +		if (fw.or_valid) {
> +			snprintf(fw_version, fw_length,
> +				 "%d.%d, 0x%08x, %d.%d.%d",
> +				 fw.eep_major, fw.eep_minor, fw.etrack_id,
> +				 fw.or_major, fw.or_build, fw.or_patch);
> +		/* no option rom */
> +		} else {
> +			if (fw.etrack_id != 0X0000) {
> +			snprintf(fw_version, fw_length,
> +				 "%d.%d, 0x%08x",
> +				 fw.eep_major, fw.eep_minor, fw.etrack_id);
> +			} else {
> +			snprintf(fw_version, fw_length,
> +				 "%d.%d.%d",
> +				 fw.eep_major, fw.eep_minor, fw.eep_build);

Indentation is incorrect here.