From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 13/13] i40e: improve message grepability Date: Mon, 9 Jan 2017 09:25:12 -0800 Message-ID: <20170109092512.08d52b9b@xeon-e3> References: <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com> <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com> <2026939.L9sH03DzKe@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Bruce Richardson , "Wu, Jingjing" , Michal Miroslaw , "Yigit, Ferruh" To: Thomas Monjalon Return-path: Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id C318D152A for ; Mon, 9 Jan 2017 18:25:15 +0100 (CET) Received: by mail-pg0-f44.google.com with SMTP id 204so23157444pge.0 for ; Mon, 09 Jan 2017 09:25:15 -0800 (PST) In-Reply-To: <2026939.L9sH03DzKe@xps13> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 09 Jan 2017 14:18:58 +0100 Thomas Monjalon wrote: > 2017-01-09 12:02, Bruce Richardson: > > On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote: =20 > > >=20 > > > =20 > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Miroslaw > > > > Sent: Tuesday, December 13, 2016 9:08 AM > > > > To: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability > > > >=20 > > > > Signed-off-by: Micha=C5=82 Miros=C5=82aw > > > > --- > > > > drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++--------------= ------------ > > > > 1 file changed, 73 insertions(+), 125 deletions(-) > > > >=20 > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e= _ethdev.c > > > > index 39fbcfe..4d73aca 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i40= e_pf > > > > *pf) > > > > pf->main_vsi_seid, 0, > > > > TRUE, NULL, NULL); > > > > if (ret) > > > > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > > > > - " frames from VSIs."); > > > > + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control > > > > frames > > > > +from VSIs."); > > > > } =20 > > >=20 > > > You are right, it makes grep easily. But it will break the coding sty= le "Line length is recommended to be not more than 80 characters, including= comments." > > >=20 > > > Any comments from committers? > > > =20 > > Being able to grep error messages is more important that having lines > > wrapped at 80 characters. I believe checkpatch ignores long strings when > > checking line lengths. =20 >=20 > I agree keeping strings is more important than checkpatch conformity. > Please, if checkpatch complains, try to tune the script checkpatch.sh. > There are some options to manage strings. Checkpatch does not complain as long as string is on one line. i.e PMD_INIT_LOG(ERR, ""Failed to add filter to drop flow control frames from VSIs.= ");