From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v6 2/4] lib: add bitrate statistics library
Date: Wed, 11 Jan 2017 08:15:02 -0800
Message-ID: <20170111081502.220f6824@xeon-e3>
References: <1484150594-3758-1-git-send-email-remy.horton@intel.com>
 <1484150594-3758-3-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id C9F92D592
 for <dev@dpdk.org>; Wed, 11 Jan 2017 17:15:12 +0100 (CET)
Received: by mail-pg0-f50.google.com with SMTP id 204so29346525pge.0
 for <dev@dpdk.org>; Wed, 11 Jan 2017 08:15:12 -0800 (PST)
In-Reply-To: <1484150594-3758-3-git-send-email-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 12 Jan 2017 00:03:12 +0800
Remy Horton <remy.horton@intel.com> wrote:

> +
> +struct rte_stats_bitrates_s *
> +rte_stats_bitrate_create(void)
> +{
> +	return rte_zmalloc(NULL, sizeof(struct rte_stats_bitrates_s), 0);
> +}
> +

You want these statistics to be cache aligned (ie not 0) to avoid
false cache sharing.

Since these statistics are often associated with a device would it
not make sense to have a NUMA socket associated with the alllocation?