From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] kni: use bulk functions to allocate and free mbufs Date: Wed, 11 Jan 2017 08:17:59 -0800 Message-ID: <20170111081759.7b1ee146@xeon-e3> References: <1483048216-2936-1-git-send-email-s.vyazmitinov@brain4net.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org To: Sergey Vyazmitinov Return-path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 1D1BC69FC for ; Wed, 11 Jan 2017 17:18:01 +0100 (CET) Received: by mail-pf0-f179.google.com with SMTP id 127so63300425pfg.1 for ; Wed, 11 Jan 2017 08:18:01 -0800 (PST) In-Reply-To: <1483048216-2936-1-git-send-email-s.vyazmitinov@brain4net.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 30 Dec 2016 04:50:16 +0700 Sergey Vyazmitinov wrote: > /** > + * Free n packets mbuf back into its original mempool. > + * > + * Free each mbuf, and all its segments in case of chained buffers. Each > + * segment is added back into its original mempool. > + * > + * @param mp > + * The packets mempool. > + * @param mbufs > + * The packets mbufs array to be freed. > + * @param n > + * Number of packets. > + */ > +static inline void rte_pktmbuf_free_bulk(struct rte_mempool *mp, > + struct rte_mbuf **mbufs, unsigned n) > +{ > + struct rte_mbuf *mbuf, *m_next; > + unsigned i; > + for (i = 0; i < n; ++i) { > + mbuf = mbufs[i]; > + __rte_mbuf_sanity_check(mbuf, 1); > + > + mbuf = mbuf->next; > + while (mbuf != NULL) { > + m_next = mbuf->next; > + rte_pktmbuf_free_seg(mbuf); > + mbuf = m_next; > + } > + } > + rte_mempool_put_bulk(mp, (void * const *)mbufs, n); > +} The mbufs may come from different pools. You need to handle that.