From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] net/virtio: fix
 performance regression due to TSO enabling
Date: Thu, 12 Jan 2017 10:30:58 +0800
Message-ID: <20170112023058.GF2402@yliu-dev.sh.intel.com>
References: <1484108832-19907-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1484108832-19907-2-git-send-email-yuanhan.liu@linux.intel.com>
 <1610499.AMUobBPor6@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jianbo Liu <jianbo.liu@linaro.org>, Jerin Jacob <jerin.jacob@cavium.com>,
 Jan Viktorin <viktorin@rehivetech.com>,
 Chao Zhu <chaozhu@linux.vnet.ibm.com>, dev@dpdk.org,
 Tan Jianfeng <jianfeng.tan@intel.com>,
 Wang Zhihong <zhihong.wang@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A08005588
 for <dev@dpdk.org>; Thu, 12 Jan 2017 03:28:58 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1610499.AMUobBPor6@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 11, 2017 at 03:51:22PM +0100, Thomas Monjalon wrote:
> 2017-01-11 12:27, Yuanhan Liu:
> > The fact that virtio net header is initiated to zero in PMD driver
> > init stage means that these costly writes are unnecessary and could
> > be avoided:
> > 
> >     if (hdr->csum_start != 0)
> >         hdr->csum_start = 0;
> > 
> > And that's what the macro ASSIGN_UNLESS_EQUAL does. With this, the
> > performance drop introduced by TSO enabling is recovered: it could
> > be up to 20% in micro benchmarking.
> 
> This patch is adding a condition to assignments.
> We need a benchmark on other architectures like ARM. Please anyone?

I think the cost of condition should be way lower than the cost from the
penalty introduced by the cache issue, that I don't see it would perform
bad on other platforms.

But, of course, testing is always welcome!

	--yliu
> 
> 
> [...]
> > +/* avoid write operation when necessary, to lessen cache issues */
> > +#define ASSIGN_UNLESS_EQUAL(var, val) do {	\
> > +	if ((var) != (val))			\
> > +		(var) = (val);			\
> > +} while (0)