From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] tools: add tags and cscope index file
 generation support
Date: Fri, 13 Jan 2017 08:20:06 +0530
Message-ID: <20170113025005.GA2951@localhost.localdomain>
References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0083.outbound.protection.outlook.com [104.47.33.83])
 by dpdk.org (Postfix) with ESMTP id D3A042C6D
 for <dev@dpdk.org>; Fri, 13 Jan 2017 03:50:27 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 12, 2017 at 02:19:44PM +0000, Ferruh Yigit wrote:
> On 11/27/2016 12:12 AM, Jerin Jacob wrote:
> > This script generates cscope, gtags, and tags
> > index files based on EAL environment.
> > (architecture and OS(linux/bsd))
> > 
> > Selection of the architecture and OS environment
> > is based on dpdk configuration target(T=)
> > 
> > example usage:
> > make tags T=x86_64-native-linuxapp-gcc
> > make cscope T=x86_64-native-linuxapp-gcc
> > make gtags T=x86_64-native-linuxapp-gcc
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> <...>
> 
> > +
> > +if [ -n "$T" ]; then
> <...>
> > +	usage $1
> > +	exit
> 
> I would prefer fallback to RTE_TARGET parsing, or processing all files (
> cscope -Rqn ), instead of exiting here, but that is your call.

I would prefer avoid any fallback(sometimes RTE_TARGET can be "build" also) and
print the usage and exit error if the requirements are not meet.

> 
> 
> Also "tags.sh" needs to be moved into "devtools" after latest updates.

Sure. I will send v2 to address this.

> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Thanks for the review.