From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] net/nfp: fix Vlan offload flags check Date: Fri, 13 Jan 2017 13:48:24 +0100 Message-ID: <20170113134824.6542fc5e@platinum> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, alejandro.lucero@netronome.com To: Ferruh Yigit Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 22E15F927 for ; Fri, 13 Jan 2017 14:49:31 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id r144so71668919wme.1 for ; Fri, 13 Jan 2017 05:49:31 -0800 (PST) In-Reply-To: <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit wrote: > On 1/12/2017 1:04 PM, Olivier Matz wrote: > > Fix typo when checking that no Vlan offload flags are passed at port > > initialization. > > > > By the way, also fix a typo in the log. > > > > Fixes: d4a27a3b092a ("nfp: add basic features") > > > > Signed-off-by: Olivier Matz > > --- > > drivers/net/nfp/nfp_net.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index 65ba09f..ed3c9b8 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev > > *dev, int mask) new_ctrl = 0; > > > > if ((mask & ETH_VLAN_FILTER_OFFLOAD) || > > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > > - RTE_LOG(INFO, PMD, "Not support for > > ETH_VLAN_FILTER_OFFLOAD or" > > + (mask & ETH_VLAN_FILTER_EXTEND)) > > I can't find "ETH_VLAN_FILTER_EXTEND", > do you mean "ETH_VLAN_EXTEND_OFFLOAD" ? Erf... I'm sorry, my mistake, I copy/pasted the log below without verifying. I saw it while watching the code. Yes I mean ETH_VLAN_EXTEND_OFFLOAD. By the way, it could even be replaced ETH_VLAN_*_MASK, but it's the same value. For reference, here are the definitions from rte_ethdev.h: /* Definitions used for VLAN Offload functionality */ #define ETH_VLAN_STRIP_OFFLOAD 0x0001 /**< VLAN Strip On/Off */ #define ETH_VLAN_FILTER_OFFLOAD 0x0002 /**< VLAN Filter On/Off */ #define ETH_VLAN_EXTEND_OFFLOAD 0x0004 /**< VLAN Extend On/Off */ /* Definitions used for mask VLAN setting */ #define ETH_VLAN_STRIP_MASK 0x0001 /**< VLAN Strip setting mask */ #define ETH_VLAN_FILTER_MASK 0x0002 /**< VLAN Filter setting mask*/ #define ETH_VLAN_EXTEND_MASK 0x0004 /**< VLAN Extend setting mask*/ I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD. Thanks Ferruh. Olivier