From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: i40e_aq_get_phy_capabilities() fails when using SFP+ with no link Date: Fri, 13 Jan 2017 14:24:55 +0100 Message-ID: <20170113142455.05ac6c06@platinum> References: <2BF7FCC7-B2DF-43EE-B5F8-2F3271FB3DA1@gmail.com> <20170110162849.2256dc6e@glumotte.dev.6wind.com> <1A089981-6412-47FD-A46A-95A958D5E206@gmail.com> <20170112145554.44506d05@glumotte.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "Rowden, Aaron F" , Christos Ricudis , "Zhang, Helin" , "dev@dpdk.org" , "Wu, Jingjing" To: Olivier MATZ Return-path: Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id DFDA468CA for ; Fri, 13 Jan 2017 14:52:48 +0100 (CET) Received: by mail-lf0-f53.google.com with SMTP id v186so38010701lfa.1 for ; Fri, 13 Jan 2017 05:52:48 -0800 (PST) In-Reply-To: <20170112145554.44506d05@glumotte.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Thu, 12 Jan 2017 14:55:54 +0100, Olivier MATZ wrote: > Hi, >=20 > On Wed, 11 Jan 2017 20:51:58 +0000, "Rowden, Aaron F" > wrote: > > Hi Helin, > >=20 > > I'm checking on this to see why it could be failing but I don=E2=80=99t > > think this is one part of formal validation. Intel modules are > > always what is recommended. > >=20 > > Aaron > > =20 > > > Hi Helin,=20 > > > =20 > > > > On 11 Jan 2017, at 09:08, Zhang, Helin > > > > wrote: > > > >=20 > > > > Hi Aaron > > > >=20 > > > > Is the SFP+ (Finisar FTLX8571D3BCL) supported and validated by > > > > Intel? It seems there is some PHY issue in this case. =20 > > >=20 > > > As the original reporter of this issue, I will test with validated > > > SFP+s and will report on my testing.=20 > > >=20 > > > Shouldn=E2=80=99t unsupported SFP+s be blacklisted in the I40E driver= ?=20 > > > =20 >=20 > Just to let you know that in my case the SFP are Intel ones. > Maybe it's a different issue. >=20 > I see there are some i40e fixes in the net-next repo, I'll give a try > with this version. The issue still exists in net-next. I did a git bissect, and the commit that introduces the issue is: f4668a33efe5 ("net/i40e: fix link status change interrupt") [1] If I revert it (with some conflicts), the problem I described in [2] disappear. Helin, Jinging, do you know what would be the consequences of reverting this patch? Christos, I don't know if it also helps for yor issue. If no, sorry for having squatted your topic, the symptoms looked quite similar at first glance. Thanks, Olivier [1] http://dpdk.org/browse/dpdk/commit/?id=3Df4668a33efe5 [2] http://dpdk.org/ml/archives/dev/2017-January/054401.html