From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] net/nfp: fix Vlan offload flags check
Date: Fri, 13 Jan 2017 15:48:02 +0100
Message-ID: <20170113154802.6166e529@platinum>
References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com>
 <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com>
 <20170113134824.6542fc5e@platinum>
 <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, alejandro.lucero@netronome.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 0030814EC
 for <dev@dpdk.org>; Fri, 13 Jan 2017 15:48:05 +0100 (CET)
Received: by mail-wm0-f47.google.com with SMTP id c206so74190253wme.0
 for <dev@dpdk.org>; Fri, 13 Jan 2017 06:48:05 -0800 (PST)
In-Reply-To: <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
<ferruh.yigit@intel.com> wrote:
> On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > <ferruh.yigit@intel.com> wrote:  
> >> On 1/12/2017 1:04 PM, Olivier Matz wrote:  
> >>> Fix typo when checking that no Vlan offload flags are passed at
> >>> port initialization.
> >>>
> >>> By the way, also fix a typo in the log.
> >>>
> >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> >>>
> >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >>> ---  
> 
> <...>
> 
> > 
> > 
> > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.  
> 
> If this will be the only change, I can update it if you want:
> 
> -   (mask & ETH_VLAN_FILTER_OFFLOAD))
> -       RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> or"
> -                       " ETH_VLAN_FILTER_EXTEND");
> +   (mask & ETH_VLAN_EXTEND_OFFLOAD))
> +       RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> +                       " ETH_VLAN_EXTEND_OFFLOAD");
> 

Looks good to me, thank you.

Olivier