From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH v5] mbuf: add a function to linearize a packet Date: Fri, 13 Jan 2017 16:32:34 +0100 Message-ID: <20170113163234.1f38b9ee@platinum> References: <1483634640-33892-1-git-send-email-tomaszx.kulasek@intel.com> <1484214044-9432-1-git-send-email-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Pablo de Lara To: Tomasz Kulasek Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 6A08969FC for ; Fri, 13 Jan 2017 16:32:37 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id r126so70042200wmr.0 for ; Fri, 13 Jan 2017 07:32:37 -0800 (PST) In-Reply-To: <1484214044-9432-1-git-send-email-tomaszx.kulasek@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 12 Jan 2017 10:40:44 +0100, Tomasz Kulasek wrote: > This patch adds function rte_pktmbuf_linearize to let crypto PMD > coalesce chained mbuf before crypto operation and extend their > capabilities to support segmented mbufs when device cannot handle > them natively. > > Included unit tests for rte_pktmbuf_linearize functionality: > > 1) Creates banch of segmented mbufs with different size and number of > segments. > 2) Fills noncontigouos mbuf with sequential values. > 3) Uses rte_pktmbuf_linearize to coalesce segmented buffer into one > contiguous. > 4) Verifies data in linearized buffer. > > Dependencies: > > This patch is rebased to the dpdk-next-crypto and should be applied > before "Chained Mbufs support in SW PMDs" patchset. > > changes in v5: > - name of patch changed, > - improved coding style, > > changes in v4: > - separated from "Chained Mbufs support in SW PMDs" patch set for > better reviewing, > - merged "rte_pktmbuf_linearize" implementation with unit tests, > > changes in v3: > - rebased to dpdk-next-crypto > > changes in v2: > - rte_pktmbuf_coalesce replaced with rte_pktmbuf_linearize > > Cc: Pablo de Lara > Cc: Olivier Matz > Signed-off-by: Tomasz Kulasek Acked-by: Olivier Matz Just one comment about the changelog for next time: as it's not something we need to keep in the git history, you can put it after the '---', so it will be dropped when applying the patch with 'git am'. Thanks, Olivier