From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] net/virtio: fix advertised Rx offload capabilities Date: Mon, 16 Jan 2017 14:12:43 +0800 Message-ID: <20170116061243.GK9770@yliu-dev.sh.intel.com> References: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Olivier Matz Return-path: Content-Disposition: inline In-Reply-To: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote: > When the virtio PMD is used on top of a vhost that does not support > offloads, Rx offload capabilities are still advertised by > virtio_dev_info_get(). But if an application tries to start the PMD with > Rx offloads enabled (rxmode.hw_ip_checksum = 1), the initialization of > the device will fail with -ENOTSUP and the following log: > > rx ip checksum not available on this host > > This patch fixes the Rx offload capabilities returned by > virtio_dev_info_get() to be consistent with features advertised by the > host. > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > Fixes: 86d59b21468a ("net/virtio: support LRO") Hi Olivier, This patch doesn't apply cleanly on top of next-virtio repo, would you midn to send v2, so that I can apply? Thanks. --yliu