From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] net/virtio: fix advertised Rx offload
	capabilities
Date: Tue, 17 Jan 2017 11:33:45 +0100
Message-ID: <20170117113345.75fc46f3@platinum>
References: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com>
 <20170116061243.GK9770@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, stable@dpdk.org
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com
 [209.85.215.41]) by dpdk.org (Postfix) with ESMTP id 37049DE5
 for <dev@dpdk.org>; Tue, 17 Jan 2017 11:33:49 +0100 (CET)
Received: by mail-lf0-f41.google.com with SMTP id n124so34664475lfd.2
 for <dev@dpdk.org>; Tue, 17 Jan 2017 02:33:49 -0800 (PST)
In-Reply-To: <20170116061243.GK9770@yliu-dev.sh.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 16 Jan 2017 14:12:43 +0800, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:
> On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote:
> > When the virtio PMD is used on top of a vhost that does not support
> > offloads, Rx offload capabilities are still advertised by
> > virtio_dev_info_get(). But if an application tries to start the PMD
> > with Rx offloads enabled (rxmode.hw_ip_checksum = 1), the
> > initialization of the device will fail with -ENOTSUP and the
> > following log:
> > 
> >   rx ip checksum not available on this host
> > 
> > This patch fixes the Rx offload capabilities returned by
> > virtio_dev_info_get() to be consistent with features advertised by
> > the host.
> > 
> > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload")
> > Fixes: 86d59b21468a ("net/virtio: support LRO")  
> 
> Hi Olivier,
> 
> This patch doesn't apply cleanly on top of next-virtio repo, would you
> midn to send v2, so that I can apply?

Sure, will do.