From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3] kni: use bulk functions to allocate and
 free mbufs
Date: Wed, 18 Jan 2017 17:03:33 +0800
Message-ID: <20170118090333.GQ10293@yliu-dev.sh.intel.com>
References: <1484729515-2949-1-git-send-email-s.vyazmitinov@brain4net.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: olivier.matz@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org,
 Stephen Hemminger <stephen@networkplumber.org>
To: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 456EE37B4
 for <dev@dpdk.org>; Wed, 18 Jan 2017 10:01:21 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1484729515-2949-1-git-send-email-s.vyazmitinov@brain4net.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 18, 2017 at 03:51:55PM +0700, Sergey Vyazmitinov wrote:
> Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk
> functions. This can improve performance more than two times.
> 
> Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
> ---
> v2:
> * CSG fixes.
> v3:
> * Fixed issue with possible different mempools in buffer list.
> * Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
> processing in the kni_allocate_mbufs.

Hi,

Few thing to note here:

- You should Cc all guys involved in last discussion, but not just the
  maintainers listed in the MAINTAINERS file. They gave your (valuable)
  comments, show some respect to them.

- You can't simply grab the code from Stephen and take it as yours.
  You don't even mention him anywhere in this patch.

  You should at least add something like "Suggested-by: Stephen ..."
  Or better, separate the patch into two: one to introduce bulk free
  and mark Stephen as the author, and another one to apply it to KNI.

	--yliu