From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix queue wrap-around of multi-packet send Date: Fri, 20 Jan 2017 17:56:47 +0100 Message-ID: <20170120165647.GL3779@6wind.com> References: <20170118005155.20192-1-yskoh@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org To: Yongseok Koh Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 83B7E2BA7 for ; Fri, 20 Jan 2017 17:56:55 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r144so53131097wme.1 for ; Fri, 20 Jan 2017 08:56:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170118005155.20192-1-yskoh@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote: > When the WQ is wrapped around, it wrongly checks the condition when > resetting the pointer. It should be compared against the end of the queue, > not the beginning of the queue. And this isn't even needed when the length > of the copying data crosses the boundary. > > Fixes: e5291c280c08 ("net/mlx5: use work queue buffer as a raw buffer") > > CC: stable@dpdk.org > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_rxtx.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Thanks for addressing this issue. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND