From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] mk: remove default toolchain prefix for
	ThunderX
Date: Mon, 23 Jan 2017 15:09:51 +0530
Message-ID: <20170123093950.GA14840@localhost.localdomain>
References: <1485162957-2497-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0070.outbound.protection.outlook.com [104.47.32.70])
 by dpdk.org (Postfix) with ESMTP id BC204108F
 for <dev@dpdk.org>; Mon, 23 Jan 2017 10:40:12 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1485162957-2497-1-git-send-email-thomas.monjalon@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> The environment variable CROSS must be set when using a cross-toolchain.
> However it is counter intuitive to set a default value, considering
> the toolchain required to build this architecture is well known.
> It is especially weird when using a native toolchain and requiring to
> unset this variable on the command line.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  mk/machine/thunderx/rte.vars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
> index 81da1b4..ad5a379 100644
> --- a/mk/machine/thunderx/rte.vars.mk
> +++ b/mk/machine/thunderx/rte.vars.mk
> @@ -47,7 +47,7 @@
>  #
>  
>  # ARCH =
> -CROSS ?= aarch64-thunderx-linux-gnu-
> +# CROSS =
>  # MACHINE_CFLAGS =
>  # MACHINE_LDFLAGS =
>  # MACHINE_ASFLAGS =
> -- 
> 2.7.0
>