From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH v6 1/2] kni: add bulk function to free mbufs Date: Mon, 23 Jan 2017 14:19:37 +0100 Message-ID: <20170123141937.75390eef@platinum> References: <1484801219-1312-1-git-send-email-s.vyazmitinov@brain4net.com> <1484801219-1312-2-git-send-email-s.vyazmitinov@brain4net.com> <20170123135947.0e5cbe83@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, stephen@networkplumber.org, yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com, dev@dpdk.org, mirqus@gmail.com To: Sergey Vyazmitinov Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 74A232C38 for ; Mon, 23 Jan 2017 14:19:40 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id r126so132501721wmr.0 for ; Mon, 23 Jan 2017 05:19:40 -0800 (PST) In-Reply-To: <20170123135947.0e5cbe83@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, [resent and updated, previous mail was sent from the wrong address] On Mon, 23 Jan 2017 13:59:47 +0100, Olivier Matz wrote: > > + * @param mbufs > > + * The packets mbufs array to be freed. > > + * @param n > > + * Number of packets. > > + */ > > +static inline void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, > > + unsigned int n) > > I suggest we could use mbuf instead of pktmbuf in the function name. > It's a bit shorter, and the function would also apply on ctrlmbuf. Sorry, please ignore this one. It's more consistent to have a rte_pktmbuf_free and rte_pktmbuf_free_bulk having the same prefix. Also a small comment on the title: it should be "mbuf:", not "kni:". In the other patch, the uppercase in "Use" could also be changed to lowercase (seen with ./devtools/check-git-log.sh). Thanks, Olivier