From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH] mk: parallelize make config
Date: Tue, 24 Jan 2017 09:42:35 +0100
Message-ID: <20170124094235.7fda08cc@glumotte.dev.6wind.com>
References: <20170122015034.19824-1-ferruh.yigit@intel.com>
 <20170123181813.00567e47@platinum>
 <5C15197B-7CD8-490D-B756-B0580CBFFA50@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Olivier Matz <olivier.matz@6wind.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 70EE1108D
 for <dev@dpdk.org>; Tue, 24 Jan 2017 09:42:42 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id r144so196557382wme.1
 for <dev@dpdk.org>; Tue, 24 Jan 2017 00:42:42 -0800 (PST)
In-Reply-To: <5C15197B-7CD8-490D-B756-B0580CBFFA50@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Keith,

On Mon, 23 Jan 2017 17:50:27 +0000, "Wiles, Keith"
<keith.wiles@intel.com> wrote:
> > On Jan 23, 2017, at 10:18 AM, Olivier Matz <olivier.matz@6wind.com>
> > wrote:
> > 
> > Hi Ferruh,
> > 
> > On Sun, 22 Jan 2017 01:50:34 +0000, Ferruh Yigit
> > <ferruh.yigit@intel.com> wrote:  
> >> make config dependency resolving was always running serial,
> >> parallelize it for better performance.
> >> 
> >> $ time make T=x86_64-native-linuxapp-gcc config
> >> real    0m12.633s
> >> 
> >> $ time make -j8 T=x86_64-native-linuxapp-gcc config
> >> real    0m1.826s
> >> 
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>  
> > 
> > I have a patch that fix the same issue (configuration takes to
> > long), but done differently. It is more intrusive, since it rework
> > the way DEPDIRS are used, but it does not require to use -j.  
> 
> I tested the patch and the performance is very quick and seems to
> work very nicely. I have not looked at the other patch yet are they
> both compatible and could be combined or not?

No, I don't think they could be combined.

Ferruh's approach looks less risky, since it's a parallelization
of the config. My approach changes the way dependencies are processed,
and also how they are declared. I think it's faster, but more intrusive.

Regards,
Olivier