From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emmanuel Roullit Subject: [PATCH] eal: fail eal when no hugepages were found Date: Tue, 24 Jan 2017 21:22:02 +0100 Message-ID: <20170124202202.31045-1-emmanuel.roullit@gmail.com> Cc: dev@dpdk.org To: david.marchand@6wind.com Return-path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 62DC1201 for ; Tue, 24 Jan 2017 21:22:28 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id r126so37350284wmr.3 for ; Tue, 24 Jan 2017 12:22:28 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found with clang static analysis: lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11: warning: Call to 'malloc' has an allocation size of 0 bytes tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The --no-huge case, where nr_hugepages would be 0 as well, is handled earlier. Fixes: 5e823a451261 ("ethdev: remove some VF functions") Signed-off-by: Emmanuel Roullit --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index a956bb226..0b0355898 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -995,6 +995,9 @@ rte_eal_hugepage_init(void) nr_hugepages += internal_config.hugepage_info[i].num_pages[0]; } + if (nr_hugepages == 0) + goto fail; + /* * allocate a memory area for hugepage table. * this isn't shared memory yet. due to the fact that we need some -- 2.11.0