From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emmanuel Roullit Subject: [PATCH] ethdev: remove useless pointer initialization Date: Tue, 24 Jan 2017 21:28:35 +0100 Message-ID: <20170124202835.1271-1-emmanuel.roullit@gmail.com> Cc: dev@dpdk.org, stable@dpdk.org To: thomas.monjalon@6wind.com Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found with clang static analysis: lib/librte_ether/rte_ethdev.c:2467:22: warning: Value stored to 'dev' during its initialization is never read struct rte_eth_dev *dev = &rte_eth_devices[port_id]; ^~~ ~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port") Signed-off-by: Emmanuel Roullit --- lib/librte_ether/rte_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 61f44e218..d7f78c23a 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -2364,7 +2364,7 @@ rte_eth_mirror_rule_set(uint8_t port_id, struct rte_eth_mirror_conf *mirror_conf, uint8_t rule_id, uint8_t on) { - struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + struct rte_eth_dev *dev; RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); if (mirror_conf->rule_type == 0) { @@ -2400,7 +2400,7 @@ rte_eth_mirror_rule_set(uint8_t port_id, int rte_eth_mirror_rule_reset(uint8_t port_id, uint8_t rule_id) { - struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + struct rte_eth_dev *dev; RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -- 2.11.0