From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] cryptodev: decouple from PCI device Date: Tue, 24 Jan 2017 20:54:18 -0800 Message-ID: <20170124205418.40ca5795@xeon-e3> References: <1484730970-2832-1-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , Hemant Agrawal , , , , To: Shreyansh Jain Return-path: Received: from mail-pg0-f54.google.com (mail-pg0-f54.google.com [74.125.83.54]) by dpdk.org (Postfix) with ESMTP id 260DEDE5 for ; Wed, 25 Jan 2017 05:54:26 +0100 (CET) Received: by mail-pg0-f54.google.com with SMTP id 14so61018449pgg.1 for ; Tue, 24 Jan 2017 20:54:26 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 25 Jan 2017 10:18:01 +0530 Shreyansh Jain wrote: > On Wednesday 18 January 2017 02:46 PM, Hemant Agrawal wrote: > > This makes struct rte_cryptodev independent of struct rte_pci_device by > > replacing it with a pointer to the generic struct rte_device. > > > > This is inline with the recent changes in ethdev > > > > Signed-off-by: Hemant Agrawal > > --- > > drivers/crypto/qat/qat_qp.c | 12 +++++++++--- > > drivers/crypto/qat/rte_qat_cryptodev.c | 6 +++--- > > lib/librte_cryptodev/rte_cryptodev.c | 6 +++--- > > lib/librte_cryptodev/rte_cryptodev.h | 4 ++-- > > 4 files changed, 17 insertions(+), 11 deletions(-) > > > > Next step would be to remove rte_pci_driver from eth_driver > and rte_cryptodev_driver and make it generic. > > Reviewed-by: Shreyansh Jain > Agreed.