From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: rte_ring features in use (or not) Date: Wed, 25 Jan 2017 08:39:34 -0800 Message-ID: <20170125083934.07678812@xeon-e3> References: <20170125121456.GA24344@bricha3-MOBL3.ger.corp.intel.com> <20170125142052.7989e0ec@glumotte.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Bruce Richardson , dev@dpdk.org To: Olivier MATZ Return-path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 4A9A91023 for ; Wed, 25 Jan 2017 17:39:42 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id e4so59175495pfg.1 for ; Wed, 25 Jan 2017 08:39:42 -0800 (PST) In-Reply-To: <20170125142052.7989e0ec@glumotte.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 25 Jan 2017 14:20:52 +0100 Olivier MATZ wrote: > > * Who uses the watermarks feature as is? I know we have a sample app > > that uses it, but there are better ways I think to achieve the same > > goal while simplifying the ring implementation. Rather than have a > > set watermark on enqueue, have both enqueue and dequeue functions > > return the number of free or used slots available in the ring (in > > case of enqueue, how many free there are, in case of dequeue, how > > many items are available). Easier to implement and far more useful to > > the app. > > +1 I did use the watermark feature once, it was for case of ring between two threads. Only wanted to wake up other thread if > N packets were in ring.