From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 15/25] eal: do not panic on alarm init Date: Fri, 27 Jan 2017 08:31:55 -0800 Message-ID: <20170127083155.71fb20cb@xeon-e3> References: <1485529023-5486-1-git-send-email-aconole@redhat.com> <1485529023-5486-16-git-send-email-aconole@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Aaron Conole Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id C7BA412A8 for ; Fri, 27 Jan 2017 17:32:02 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id 189so74469830pfu.3 for ; Fri, 27 Jan 2017 08:32:02 -0800 (PST) In-Reply-To: <1485529023-5486-16-git-send-email-aconole@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 27 Jan 2017 09:56:53 -0500 Aaron Conole wrote: > + if (rte_eal_alarm_init() < 0) { > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > + /* rte_eal_alarm_init sets rte_errno on failure. */ > + errno = rte_errno; Hmm. DPDK in general does not reset errno but instead uses error code directly on return (best) or in some cases rte_errno