From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/virtio-user: check value returned from
	malloc
Date: Sat, 28 Jan 2017 21:26:21 +0800
Message-ID: <20170128132621.GB20916@yliu-dev.sh.intel.com>
References: <1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, john.mcnamara@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 9EBDB98
 for <dev@dpdk.org>; Sat, 28 Jan 2017 14:23:58 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 26, 2017 at 03:05:42AM +0000, Jianfeng Tan wrote:
> Value returned from malloc is not checked for errors before being used.
> This patch fixes following coverity issue.
> 
>     static struct vhost_memory_kernel *
>     prepare_vhost_memory_kernel(void)
>     {
>         ...
>         vm = malloc(sizeof(struct vhost_memory_kernel) +
>                     max_regions *
>                     sizeof(struct vhost_memory_region));
>         ...
>     >>>     CID 140744:    (NULL_RETURNS)
>     >>>     Dereferencing a null pointer "vm".
>                 mr = &vm->regions[k++];
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Coverity issue: 140744
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied to dpdk-next-virtio.

	--yliu