From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Cc: huawei.xie@intel.com, dev@dpdk.org
Subject: Re: [PATCH] vhost: remove unneeded variable assignment
Date: Mon, 30 Jan 2017 20:47:13 +0800 [thread overview]
Message-ID: <20170130124713.GG20916@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170124203129.2850-1-emmanuel.roullit@gmail.com>
On Tue, Jan 24, 2017 at 09:31:29PM +0100, Emmanuel Roullit wrote:
> Found with clang static analysis:
> lib/librte_vhost/vhost_user.c:996:3: warning:
> Value stored to 'ret' is never read
> ret = vhost_user_get_vring_base(dev, &msg.payload.state);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 73c8f9f69c6c ("vhost: introduce reply ack feature")
Again, you were referencing the bad commit. For this case, I'd like to
remove such fixline, as this patch doesn't really "fix" anything. But
since you made it, I could apply it.
So applied to dpdk-next-virtio.
--yliu
prev parent reply other threads:[~2017-01-30 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:31 [PATCH] vhost: remove unneeded variable assignment Emmanuel Roullit
2017-01-30 12:47 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130124713.GG20916@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).