From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] vhost: remove unneeded variable assignment
Date: Mon, 30 Jan 2017 20:47:13 +0800
Message-ID: <20170130124713.GG20916@yliu-dev.sh.intel.com>
References: <20170124203129.2850-1-emmanuel.roullit@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: huawei.xie@intel.com, dev@dpdk.org
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 67ACA2BAE
 for <dev@dpdk.org>; Mon, 30 Jan 2017 13:44:50 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20170124203129.2850-1-emmanuel.roullit@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 24, 2017 at 09:31:29PM +0100, Emmanuel Roullit wrote:
> Found with clang static analysis:
> lib/librte_vhost/vhost_user.c:996:3: warning:
> Value stored to 'ret' is never read
>         ret = vhost_user_get_vring_base(dev, &msg.payload.state);
>         ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 73c8f9f69c6c ("vhost: introduce reply ack feature")

Again, you were referencing the bad commit. For this case, I'd like to
remove such fixline, as this patch doesn't really "fix" anything. But
since you made it, I could apply it.

So applied to dpdk-next-virtio.

	--yliu