From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/6] net/tap: use correct channel for error logs Date: Tue, 31 Jan 2017 08:58:30 -0800 Message-ID: <20170131085830.341b494d@xeon-e3> References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <1485855778-15496-2-git-send-email-pascal.mazon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Pascal Mazon , keith.wiles@intel.com, dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 850D4FFA for ; Tue, 31 Jan 2017 17:58:38 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id f144so108421072pfa.2 for ; Tue, 31 Jan 2017 08:58:38 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 31 Jan 2017 13:07:37 +0000 Ferruh Yigit wrote: > On 1/31/2017 9:42 AM, Pascal Mazon wrote: > > Signed-off-by: Pascal Mazon > > --- > > looks good to me. > Agreed, almost all uses of INFO as log level are wrong! Either the message is reporting a problem should be NOTICE, WARN, ERR or the message is often just developer checking the code and should be DEBUG.