From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix link status
	query
Date: Thu, 2 Feb 2017 09:20:27 +0100
Message-ID: <20170202082027.GL16389@autoinstall.dev.6wind.com>
References: <1485348178-43771-1-git-send-email-shahafs@mellanox.com>
 <1485863129-6326-1-git-send-email-shahafs@mellanox.com>
 <20170131154201.GC16389@autoinstall.dev.6wind.com>
 <d5512631-529c-fd2d-14fb-d829c971e2d1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Shahaf Shuler <shahafs@mellanox.com>, adrien.mazarguil@6wind.com,
 dev@dpdk.org, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id D23AFFFA
 for <dev@dpdk.org>; Thu,  2 Feb 2017 09:20:35 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id b65so78413499wmf.0
 for <dev@dpdk.org>; Thu, 02 Feb 2017 00:20:35 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <d5512631-529c-fd2d-14fb-d829c971e2d1@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Feb 01, 2017 at 06:31:17PM +0000, Ferruh Yigit wrote:
> On 1/31/2017 3:42 PM, Nélio Laranjeiro wrote:
> > On Tue, Jan 31, 2017 at 01:45:29PM +0200, Shahaf Shuler wrote:
> >> Trying to query the link status through new kernel ioctl API
> >> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
> >> The bug was fixed on version 4.9
> >> this patch uses the legacy ioctl API for lower kernels.
> >>
> >> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
> >> CC: stable@dpdk.org
> >>
> >> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> Applied to dpdk-next-net/master, thanks.
> 
> (Updated kernel version check to:
> "+#if KERNEL_VERSION(4, 9, 0) < LINUX_VERSION_CODE")

Ferruh,

The issue is fixed in 4.9, so <= 4.9 is correct.

Am I missing something?

Regards,

-- 
Nélio Laranjeiro
6WIND