From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [libvirt] [RFC] Vhost-user backends cross-version
 migration support
Date: Thu, 2 Feb 2017 15:06:21 +0000
Message-ID: <20170202150621.GQ2915@redhat.com>
References: <f82e4c29-9866-ab2d-7553-7b994782358c@redhat.com>
 <c6749217-a85e-f27c-308d-41c93e973953@redhat.com>
 <20170201094304.GA3232@redhat.com>
 <f7454909-a95a-9438-c2ac-26bcde83601c@redhat.com>
 <20170201114119.GE3232@redhat.com>
 <f5870309-66f5-dcca-b9ec-93986156692c@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Michal Privoznik <mprivozn@redhat.com>,
 Kevin Traynor <ktraynor@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Ciara Loftus <ciara.loftus@intel.com>, mark.b.kavanagh@intel.com,
 Flavio Leitner <fleitner@redhat.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Daniele Di Proietto <diproiettod@vmware.com>,
 "dev@openvswitch.org" <dev@openvswitch.org>, "dev@dpdk.org" <dev@dpdk.org>,
 "libvir-list@redhat.com" <libvir-list@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2E5F42BCD
 for <dev@dpdk.org>; Thu,  2 Feb 2017 16:06:30 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <f5870309-66f5-dcca-b9ec-93986156692c@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote:
> 
> 
> On 02/01/2017 12:41 PM, Daniel P. Berrange wrote:
> > 
> > It depends where / how in OVS it needs to be set. The only stuff libvirt
> > does with OVS is to run 'add-port' and 'del-port' commands via the ovs
> > cli tool. We pass through arguments from the port profile stored in the
> > XML config.
> > 
> >   <interface type='bridge'>
> >     <source bridge='ovsbr'/>
> >     <virtualport type='openvswitch'>
> >       <parameters profileid='menial' interfaceid='09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f'/>
> >     </virtualport>
> >   </interface>
> > 
> > eg those things in <parameters/> get passed as cli args to the 'add-port'
> > command. Soo if add-port needs this new version string, then we'd need
> > to add the version to the openvswitch virtualport XML.
> > 
> > If the version is provided to OVS in a different command, then it would
> > probably be outside scope of libvirt.
> 
> I think it would make sense to be a parameter of the add-port command.
> But it would be for vhost-user related add-port command, I didn't find
> where/if this is managed in libvirt XML.

For vhost-user, libvirt does not have any interaction with OVS at
all. If the thing that's using the vhost-user UNIX socket, in turn
connects to OVS, that's outside scope of libvirt. IOW, for vhost-user
OVS it seems like that job is for Nova / os-vif to solve.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|