From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH 1/3] net/mlx5: fix Ethernet header re-writing Date: Thu, 2 Feb 2017 17:38:31 +0100 Message-ID: <20170202163831.GS16389@autoinstall.dev.6wind.com> References: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: guillaume.gaudonville@6wind.com, dev@dpdk.org, Adrien Mazarguil , Yongseok Koh To: Ferruh Yigit Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 9B64FFFA for ; Thu, 2 Feb 2017 17:38:39 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id r141so96941704wmg.1 for ; Thu, 02 Feb 2017 08:38:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On Thu, Feb 02, 2017 at 03:34:04PM +0000, Ferruh Yigit wrote: > On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote: > > First two bytes of the Ethernet header was written twice at the same place. > > Is this patch just prevents re-writing 2 bytes of buffer, or changes the > buffer content as well? It only prevents to re-write 2 bytes of the buffer. > If buffer content also updated, I think it would be nice to mention in > the commit log. The buffer is only read. > And if buffer content is not changed, will it be fair to say this patch > is refactor patch instead of fix? Well, I understand that it can be seen as not being a fix as the final behavior remains the same. Is it possible to change it to: "net/mlx5: avoid re-writing first 2 bytes of Ethernet header" > > Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization") > > > > Signed-off-by: Yongseok Koh > > Signed-off-by: Nelio Laranjeiro > > --- > <...> Regards, -- Nélio Laranjeiro 6WIND