From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] net/ixgbe: output details on failure to
 configure filter
Date: Sat, 4 Feb 2017 13:50:58 -0800
Message-ID: <20170204135058.1cd43023@xeon-e3>
References: <1486197474-53099-1-git-send-email-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com
To: Wei Dai <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id BF796FFA
 for <dev@dpdk.org>; Sat,  4 Feb 2017 22:51:01 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id f144so14131398pfa.2
 for <dev@dpdk.org>; Sat, 04 Feb 2017 13:51:01 -0800 (PST)
In-Reply-To: <1486197474-53099-1-git-send-email-wei.dai@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat,  4 Feb 2017 16:37:54 +0800
Wei Dai <wei.dai@intel.com> wrote:

> +		PMD_INIT_LOG(ERR, "If ixgbe MAC type is not X550 or X550EM_x or "
> +			"X550EM_a, the filter mode must be signature or perfect, other mode "
> +			"is not supported ! Current MAC type = %d filter mode = %d",
> +			(int)(hw->mac.type), (int)mode);
>  		return -ENOSYS;

Having better messages is good. Please punctuate correctly, and ! is not necessary.

Please try and keep it to one line, having really long log messages doesn't help.
Also, breaking a string makes it harder to use grep to find the source.