From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 4/6] eventdev: implement PMD registration
 functions
Date: Sun, 5 Feb 2017 18:34:22 +0530
Message-ID: <20170205130421.GA13302@localhost.localdomain>
References: <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1482312326-2589-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1482312326-2589-5-git-send-email-jerin.jacob@caviumnetworks.com>
 <AM5PR0401MB2514BB53BFDA87C3C1EEC1C6E64C0@AM5PR0401MB2514.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "bruce.richardson@intel.com"
 <bruce.richardson@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 "gage.eads@intel.com" <gage.eads@intel.com>, "harry.van.haaren@intel.com"
 <harry.van.haaren@intel.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0071.outbound.protection.outlook.com [104.47.37.71])
 by dpdk.org (Postfix) with ESMTP id D4B99F72
 for <dev@dpdk.org>; Sun,  5 Feb 2017 14:04:48 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <AM5PR0401MB2514BB53BFDA87C3C1EEC1C6E64C0@AM5PR0401MB2514.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Feb 02, 2017 at 11:20:09AM +0000, Nipun Gupta wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Wednesday, December 21, 2016 14:55
> > To: dev@dpdk.org
> > Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant
> > Agrawal <hemant.agrawal@nxp.com>; gage.eads@intel.com;
> > harry.van.haaren@intel.com; Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v4 4/6] eventdev: implement PMD registration
> > functions
> > 
> > This patch adds infrastructure for registering the vdev or
> > the PCI based event device.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  lib/librte_eventdev/rte_eventdev.c           | 236
> > +++++++++++++++++++++++++++
> >  lib/librte_eventdev/rte_eventdev_pmd.h       | 111 +++++++++++++
> >  lib/librte_eventdev/rte_eventdev_version.map |   6 +
> >  3 files changed, 353 insertions(+)
> > 
> 
> <snip>
> 
> > +
> > +struct rte_eventdev *
> > +rte_event_pmd_vdev_init(const char *name, size_t dev_private_size,
> > +		int socket_id)
> 
> Isn't there any requirement to have a clean-up function corresponding to
> rte_event_pmd_vdev_init?

I can add one for completeness. I will send a patch on this.

> 
> > +{
> > +	struct rte_eventdev *eventdev;
> > +
> > +	/* Allocate device structure */
> > +	eventdev = rte_event_pmd_allocate(name, socket_id);
> > +	if (eventdev == NULL)
> > +		return NULL;
> > +
> 
> <snip>
> 
> Regards,
> Nipun