From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx
 flags
Date: Mon, 6 Feb 2017 11:26:37 +0100
Message-ID: <20170206112637.5a011a7a@platinum>
References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com>
 <1486179375-133509-1-git-send-email-jingjing.wu@intel.com>
 <1486179375-133509-3-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, helin.zhang@intel.com, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 8A31B14EC
 for <dev@dpdk.org>; Mon,  6 Feb 2017 11:26:40 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id c85so113496205wmi.1
 for <dev@dpdk.org>; Mon, 06 Feb 2017 02:26:40 -0800 (PST)
In-Reply-To: <1486179375-133509-3-git-send-email-jingjing.wu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jingjing,

On Sat,  4 Feb 2017 11:36:12 +0800, Jingjing Wu <jingjing.wu@intel.com>
wrote:
> Some Tx offload flags are missed in bitmask of all supported packet
> Tx flags by i40e.
> This patch fixes it.

Could you detail which flag was missing?
Is it PKT_TX_TUNNEL_MASK?
If yes, shouldn't we have a "Fixes:" line?

I think most of the patchset should be merged in one patch, because
changing only the mbuf part (PKT_TX_OFFLOAD_MASK) would break the
drivers that checks the offload bits at init, and this is not suitable,
especially if we want to be able to do git bisect.


My suggestion is to have:

1- fix i40 (add missing tunnel mask?)
2- fix missing MACSET in TX_OFFLOAD_MASK
3- change TX_OFFLOAD_MASK to include all flags (this impacts all
   drivers using TX_OFFLOAD_MASK)


Regards,
Olivier