From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] net/ixgbevf: reset hardware when stopping port Date: Mon, 6 Feb 2017 14:58:57 +0100 Message-ID: <20170206145857.34cc54da@platinum> References: <1484153524-19337-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Guo Fengtian , stable@dpdk.org, David Marchand To: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 718DD3989 for ; Mon, 6 Feb 2017 14:59:03 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id c85so121518682wmi.1 for ; Mon, 06 Feb 2017 05:59:03 -0800 (PST) In-Reply-To: <1484153524-19337-1-git-send-email-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Wed, 11 Jan 2017 17:52:04 +0100, Olivier Matz wrote: > From: Guo Fengtian > > When PF triggers a reset, VF port must acknowledge it by calling > ixgbe_reset_hw(). > > Before this patch, the port link status, speed and duplex are invalid > (all set to 0). > > The patch move the call to ixgbe_reset_hw() from ixgbevf_dev_close() > to ixgbevf_dev_stop(), so that after a port restart on the VM, the > link status is properly marked down, with correct speed and duplex. > > Fixes: f0160874c041 ("ixgbe: various updates") > > CC: stable@dpdk.org > Signed-off-by: Guo Fengtian > Signed-off-by: David Marchand > Signed-off-by: Olivier Matz > --- > > Hi, > > The use case for this problem was described some time ago, see: > http://dpdk.org/ml/archives/dev/2015-December/030067.html > > It is also part of 2.2 release note: > http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_2_2.rst#n471 > > Regards, > Olivier Ping Thanks, Olivier