From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Wiles Subject: [PATCH v3 7/7] net/tap: move closing fds to pmd close from pmd stop Date: Mon, 6 Feb 2017 13:40:38 -0600 Message-ID: <20170206194038.9246-7-keith.wiles@intel.com> References: <20170206194038.9246-1-keith.wiles@intel.com> Cc: pascal.mazon@6wind.com, ferruh.yigit@intel.com To: dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AD5402B84 for ; Mon, 6 Feb 2017 20:40:44 +0100 (CET) In-Reply-To: <20170206194038.9246-1-keith.wiles@intel.com> In-Reply-To: <20170202223330.39240-1-keith.wiles@intel.com> References: <20170202223330.39240-1-keith.wiles@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" At the same time remove closing fds code from pmd stop routine. Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 966e91a..0a7f4af 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev) static void tap_dev_stop(struct rte_eth_dev *dev) { - int i; - struct pmd_internals *internals = dev->data->dev_private; - tap_link_set_down(dev); - - for (i = 0; i < internals->nb_queues; i++) - if (internals->rxq[i].fd != -1) - close(internals->rxq[i].fd); } static int @@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev) static void tap_dev_close(struct rte_eth_dev *dev __rte_unused) { + int i; + struct pmd_internals *internals = dev->data->dev_private; + + tap_link_set_down(dev); + + for (i = 0; i < internals->nb_queues; i++) { + if (internals->rxq[i].fd != -1) + close(internals->rxq[i].fd); + internals->rxq[i].fd = -1; + internals->txq[i].fd = -1; + } } static void -- 2.8.0.GIT