From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [PATCH v3 7/7] net/tap: move closing fds to pmd
 close from pmd stop
Date: Tue, 7 Feb 2017 09:51:12 +0100
Message-ID: <20170207095112.2e7a2551@paques.dev.6wind.com>
References: <20170206194038.9246-1-keith.wiles@intel.com>
 <20170206194038.9246-7-keith.wiles@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Keith Wiles <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com
 [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id E10B9F72
 for <dev@dpdk.org>; Tue,  7 Feb 2017 09:51:20 +0100 (CET)
Received: by mail-wr0-f182.google.com with SMTP id o16so36200792wra.1
 for <dev@dpdk.org>; Tue, 07 Feb 2017 00:51:20 -0800 (PST)
In-Reply-To: <20170206194038.9246-7-keith.wiles@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon,  6 Feb 2017 13:40:38 -0600
Keith Wiles <keith.wiles@intel.com> wrote:

> At the same time remove closing fds code from pmd stop routine.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 966e91a..0a7f4af 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev)
>  static void
>  tap_dev_stop(struct rte_eth_dev *dev)
>  {
> -	int i;
> -	struct pmd_internals *internals = dev->data->dev_private;
> -
>  	tap_link_set_down(dev);
> -
> -	for (i = 0; i < internals->nb_queues; i++)
> -		if (internals->rxq[i].fd != -1)
> -			close(internals->rxq[i].fd);
>  }
>  
>  static int
> @@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev)
>  static void
>  tap_dev_close(struct rte_eth_dev *dev __rte_unused)
>  {
> +	int i;
> +	struct pmd_internals *internals = dev->data->dev_private;
> +
> +	tap_link_set_down(dev);
> +
> +	for (i = 0; i < internals->nb_queues; i++) {
> +		if (internals->rxq[i].fd != -1)
> +			close(internals->rxq[i].fd);
> +		internals->rxq[i].fd = -1;
> +		internals->txq[i].fd = -1;
> +	}
>  }
>  
>  static void

Ok, the series looks good to me.

Acked-by: Pascal Mazon <pascal.mazon@6wind.com>