From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] doc: announce API/ABI changes for vhost Date: Tue, 14 Feb 2017 08:51:05 +0530 Message-ID: <20170214032105.GC3131@localhost.localdomain> References: <1485176682-12379-1-git-send-email-yuanhan.liu@linux.intel.com> <11273851.Pnx70jxc9N@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Yuanhan Liu , dev@dpdk.org, Maxime Coquelin , John McNamara , Ben Walker To: Thomas Monjalon Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0081.outbound.protection.outlook.com [104.47.41.81]) by dpdk.org (Postfix) with ESMTP id 0A1062A5E for ; Tue, 14 Feb 2017 04:21:26 +0100 (CET) Content-Disposition: inline In-Reply-To: <11273851.Pnx70jxc9N@xps13> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 13, 2017 at 07:02:56PM +0100, Thomas Monjalon wrote: > 2017-01-23 21:04, Yuanhan Liu: > > I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue > > forever. Well, apparently, I lied. > > > > People are looking for more vhost-user options now days, other than > > vhost-user net only. For example, SPDK (Storage Performance Development > > Kit) are looking for chance of vhost-user SCSI and vhost-user block. > > > > Apparently, they also need a vhost-user backend, while DPDK already > > has a (mature enough) backend, they don't want to implement it again > > from scratch. They want to leverage the one DPDK provides. > > > > However, the last refactoring hasn't done that right, at least it's > > not friendly for extending vhost-user to add more devices support. > > For example, different virtio devices has its own feature set, while > > APIs like rte_vhost_feature_disable(feature_mask) have no option to > > tell the device type. Thus, a more proper API should look like: > > > > rte_vhost_feature_disable(device_type, feature_mask); > > > > Besides that, few public files and structures should be renamed, to > > not let it bind to virtio-net. Specifically, they are: > > > > - virtio_net_device_ops --> vhost_device_ops > > - rte_virtio_net.h --> rte_vhost.h > > > > Signed-off-by: Yuanhan Liu > > Acked-by: Thomas Monjalon Acked-by: Jerin Jacob