From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 2/3] net/cxgbe: remove unused variable usage
Date: Tue, 14 Feb 2017 14:10:24 +0800
Message-ID: <20170214061024.GS20916@yliu-dev.sh.intel.com>
References: <20170124204859.8998-1-emmanuel.roullit@gmail.com>
 <20170124204859.8998-2-emmanuel.roullit@gmail.com>
 <4742eebd-1712-db20-26b0-d2a8e1f9aaf8@intel.com>
 <20170126044123.GA6590@chelsio.com>
 <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Emmanuel Roullit <emmanuel.roullit@gmail.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote:
> On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote:
> > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote:
> >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> >>> Found with clang static analysis:
> >>> drivers/net/cxgbe/sge.c:900:3: warning:
> >>> Value stored to 'in_use' is never read
> >>>         in_use += q->size;
> >>>         ^         ~~~~~~~
> >>>
> >>> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
> > 
> > This fixes line seems to be wrong.  Should be:
> > 
> 
> > 
> >>>
> >>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> > Fixes: 4a01078b4fd1 ("cxgbe: add Tx support")
> Cc: stable@dpdk.org

I doubt the necessary of picking it to a stable release: it doesn't fix
a real bug after all. Therefore, I will drop it for v16.11.1.

	--yliu 
> 
> Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> 
> 
> Applied to dpdk-next-net/master, thanks.
> 
> (patch 2/3 and 3/3 merged)