From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 3/4] mk: add new test-run make rule
Date: Thu, 16 Feb 2017 09:08:41 +0000
Message-ID: <20170216090841.GA92400@bricha3-MOBL3.ger.corp.intel.com>
References: <20170214151326.7554-1-ferruh.yigit@intel.com>
 <20170215152632.25081-1-ferruh.yigit@intel.com>
 <20170215152632.25081-3-ferruh.yigit@intel.com>
 <20170215170724.GA89892@bricha3-MOBL3.ger.corp.intel.com>
 <81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org,
 John McNamara <john.mcnamara@intel.com>,
 Keith Wiles <keith.wiles@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 269252B8E
 for <dev@dpdk.org>; Thu, 16 Feb 2017 10:08:45 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Feb 15, 2017 at 05:41:08PM +0000, Ferruh Yigit wrote:
> On 2/15/2017 5:07 PM, Bruce Richardson wrote:
> > On Wed, Feb 15, 2017 at 03:26:31PM +0000, Ferruh Yigit wrote:
> >> Since "make test" and "make test-build" does dependency resolving, they
> >> check for all dependent components (lib and drivers) which takes a few
> >> seconds.
> >>
> >> This is a good feature during development, but if the target is just
> >> running unit test, that step is unnecessary, it is possible to compile
> >> onece and run unit test multiple times, without checking any code update
> >>
> >> For this purpose, a new make rule "make test-run" added. Which just runs
> >> the unit test, expects that unit test already compiled.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >> ---
> > Sorry, I just don't see the point of having an extra command to maintain
> > and document for the sake of a few seconds on a unit test run. How long
> > does the run itself take compared to the time to check dependencies? 
> 
> It is matter of choice, it does not take much time for "make test", but
> still I thought it is handy to have a rule only to run the test.
> 
> I don't expect much maintenance cost with this, also I don't have strong
> opinion to keep it.
> 
Yes, I suppose it isn't much maintenance cost indeed, so if nobody else
cares, I'm ok with it too.

/Bruce