From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4] eal: Support running as unprivileged user
Date: Fri, 17 Feb 2017 11:28:32 -0800
Message-ID: <20170217112832.1099e809@plumbers-lap.home.lan>
References: <20170131174054.15324-1-benjamin.walker@intel.com>
 <20170131174453.15796-1-benjamin.walker@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ben Walker <benjamin.walker@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 867DF2C60
 for <dev@dpdk.org>; Fri, 17 Feb 2017 20:28:36 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id e4so15505652pfg.1
 for <dev@dpdk.org>; Fri, 17 Feb 2017 11:28:36 -0800 (PST)
In-Reply-To: <20170131174453.15796-1-benjamin.walker@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 31 Jan 2017 10:44:53 -0700
Ben Walker <benjamin.walker@intel.com> wrote:

> +	if (physaddr == RTE_BAD_PHYS_ADDR) {
>  		RTE_LOG(ERR, EAL,
> -			"Cannot open /proc/self/pagemap: %s. "
> -			"virt2phys address translation will not work\n",
> +			"Cannot obtain physical addresses: %s. "
> +			"Only vfio will function.\n",

Please don't split a single error message across multiple lines. It makes
it harder for user to find the source code lines with simple grep.
Better to just have one long line for format string, or better yet be less wordy.

Yes, the existing DPDK code has lots of these issues.