From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v3 02/17] eventdev: increase size of enq deq conf variables Date: Sun, 19 Feb 2017 17:35:00 +0530 Message-ID: <20170219120459.GA7400@localhost.localdomain> References: <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-3-git-send-email-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Harry van Haaren Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0087.outbound.protection.outlook.com [104.47.38.87]) by dpdk.org (Postfix) with ESMTP id 9DB3F2C50 for ; Sun, 19 Feb 2017 13:05:24 +0100 (CET) Content-Disposition: inline In-Reply-To: <1487343252-16092-3-git-send-email-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 17, 2017 at 02:53:57PM +0000, Harry van Haaren wrote: > Large port enqueue sizes were not supported as the value > it was stored in was a uint8_t. Using uint8_ts to save > space in config apis makes no sense - increasing the 3 > instances of uint8_t enqueue / dequeue depths to more > appropriate values (based on the context around them). > > Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob > --- > lib/librte_eventdev/rte_eventdev.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index b0c7f9c..8b6cb7a 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -426,7 +426,7 @@ struct rte_event_dev_config { > * This value cannot exceed the *max_event_queue_flows* which previously > * provided in rte_event_dev_info_get() > */ > - uint8_t nb_event_port_dequeue_depth; > + uint32_t nb_event_port_dequeue_depth; > /**< Maximum number of events can be dequeued at a time from an > * event port by this device. > * This value cannot exceed the *max_event_port_dequeue_depth* > @@ -637,12 +637,12 @@ struct rte_event_port_conf { > * which was previously supplied to rte_event_dev_configure(). > * This should be set to '-1' for *open system*. > */ > - uint8_t dequeue_depth; > + uint16_t dequeue_depth; > /**< Configure number of bulk dequeues for this event port. > * This value cannot exceed the *nb_event_port_dequeue_depth* > * which previously supplied to rte_event_dev_configure() > */ > - uint8_t enqueue_depth; > + uint16_t enqueue_depth; > /**< Configure number of bulk enqueues for this event port. > * This value cannot exceed the *nb_event_port_enqueue_depth* > * which previously supplied to rte_event_dev_configure() > -- > 2.7.4 >