From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] vhost: try to shrink pfdset when fdset_add
	fails
Date: Thu, 23 Feb 2017 12:37:15 +0800
Message-ID: <20170223043715.GT18844@yliu-dev.sh.intel.com>
References: <20170221142530.31472-1-matthias.gatto@outscale.com>
 <20170222015931.GK18844@yliu-dev.sh.intel.com>
 <CAAsw5BcH6H5qZC31uwJj1Y8nVGMNTdzguE5nxFNe6-787FEy6w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, stable@dpdk.org
To: Matthias Gatto <matthias.gatto@outscale.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <CAAsw5BcH6H5qZC31uwJj1Y8nVGMNTdzguE5nxFNe6-787FEy6w@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Feb 22, 2017 at 11:01:43AM +0100, Matthias Gatto wrote:
> On Wed, Feb 22, 2017 at 2:59 AM, Yuanhan Liu
> <yuanhan.liu@linux.intel.com> wrote:
> >
> > On Tue, Feb 21, 2017 at 03:25:30PM +0100, Matthias Gatto wrote:
> > > fdset_add increment pfdset->num, but fdset_del doesn't decrement pfdset->num,
> > > so if we call fdset_add then fdset_del in a loop witout calling
> > > fdset_shrink, we can easily exceed MAX_FDS with only a few number of fds
> > > used.
> >
> > I'm assuming you were doing some tests like following?
> >
> >         while true; do
> >                 ovs-vsctl add-port br vhost_n -- ...
> >                 ovs-vsctl del-port vhost_n
> >         done
> >
> 
> Something pretty close to this yes.

    Fixes: 59317cef249c ("vhost: allow many vhost-user ports")
    
    Cc: stable@dpdk.org

And applied to dpdk-next-virtio, with few typos in commit log fixed.

Thanks!

	--yliu