From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 0/8] QoS features on i40e
Date: Thu, 23 Feb 2017 22:55:07 -0800
Message-ID: <20170223225507.69ee0e47@xeon-e3>
References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id 31A662BAA
 for <dev@dpdk.org>; Fri, 24 Feb 2017 07:55:16 +0100 (CET)
Received: by mail-pg0-f50.google.com with SMTP id z128so7760466pgb.0
 for <dev@dpdk.org>; Thu, 23 Feb 2017 22:55:16 -0800 (PST)
In-Reply-To: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 24 Feb 2017 11:24:27 +0800
Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:

> This patch set enables several QoS features on i40e.
> 1, VF max bandwidth setting.
> 2, TC min bandwidth setting on a VF.
> 3, TC max bandwidth setting on a VF.
> 4, TC TX scheduling mode setting.
> As there're no new interface between PF and VF defined, all the settings
> for VF are done on PF. PF acts as a controller for the VFs.
> 
> Wenzhuo Lu (8):
>   net/i40e: set VF max bandwidth from PF
>   net/i40e: allocate VF TC bandwidth from PF
>   net/i40e: set VF TC max bandwidth from PF
>   net/i40e: set TC strict priority mode
>   app/testpmd: set VF TX max bandwidth
>   app/testpmd: set VF TC TX min bandwidth
>   app/testpmd: set VF TC TX max bandwidth
>   app/testpmd: set TC strict link priority mode
> 
>  app/test-pmd/cmdline.c                      | 343 +++++++++++++++++++++
>  doc/guides/nics/i40e.rst                    |  21 ++
>  doc/guides/rel_notes/release_17_05.rst      |  20 ++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  28 ++
>  drivers/net/i40e/i40e_ethdev.c              | 449 ++++++++++++++++++++++++++++
>  drivers/net/i40e/i40e_ethdev.h              |   1 +
>  drivers/net/i40e/rte_pmd_i40e.h             |  86 ++++++
>  drivers/net/i40e/rte_pmd_i40e_version.map   |  10 +
>  8 files changed, 958 insertions(+)
> 

It is good to allow setting QoS on device, but it looks like this is
a device specific API, not a generic PMD function. I don't think any
feature in DPDK should be hardcoded to one device type.