From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 2/2] net/virtio-user: fix multi-process issue Date: Tue, 28 Feb 2017 14:40:16 +0800 Message-ID: <20170228064016.GL18844@yliu-dev.sh.intel.com> References: <1487851096-32479-1-git-send-email-amis@radware.com> <1488102926-24158-1-git-send-email-amis@radware.com> <1488102926-24158-3-git-send-email-amis@radware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Ami Sabo Return-path: Content-Disposition: inline In-Reply-To: <1488102926-24158-3-git-send-email-amis@radware.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Feb 26, 2017 at 11:55:26AM +0200, Ami Sabo wrote: > Secondary process doesn't properly attach to the rte_eth_device > initialized by the primary process. > > ccessing device from secondary process (e.g. via rte_eth_rx_burst), > causes process to crash. because rte_eth_dev_data is not properly set. > > The issue was flood by > 'commit 7f95f78a8aea ("ethdev: clear data when allocating device")' > which now clears rte_eth_dev_data entry. > For pci devices the struct is initialized by rte_eth_dev_pci_probe > ->eth_dev_attach_secondary(). > However, for virtio-user virtio_user_pmd_probe() is called instead of > rte_eth_dev_pci_probe(). > > The fix is to call rte_eth_dev_attach_secondary(), for secondary > process, from virtio_user_pmd_probe. > > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Are you sure that's the real culprit? As I'm aware of, virtio-user is not built with multiple process support in the beginning. That said, it's likely that the first commit introduces virtio-user is the "culprit" commit. Besides that, the code looks good to me. If Thomas is fine with your first patch, I could merge them to my tree. --yliu