From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 11/15] net/avp: packet receive functions
Date: Tue, 28 Feb 2017 10:27:01 +0000
Message-ID: <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com>
References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-12-git-send-email-allain.legacy@windriver.com>
 <20170227084615.7ff06316@xeon-e3>
 <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "YIGIT, FERRUH" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Legacy, Allain" <Allain.Legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 701B22B88
 for <dev@dpdk.org>; Tue, 28 Feb 2017 11:27:16 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Feb 27, 2017 at 05:06:24PM +0000, Legacy, Allain wrote:
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > On Sun, 26 Feb 2017 14:08:59 -0500
> > Allain Legacy <allain.legacy@windriver.com> wrote:
> > 
> > Try not to break error messages onto two lines, it makes it harder when a
> > user is trying to find the location of the error message with search tools
> That's our normal practice, but checkpatches.sh flagged them as warnings.   If these are acceptable exceptions to the tool then are there plans to publish an exhaustive list of checkpatches.sh errors/warnings/checks that can be ignored?  Alternatively, are there plans to change the tools to ignore these automatically and not flag them as issues.   As a contributor it is difficult to tell what will be deemed acceptable and what will not (in some cases) so the default position is to fix all issues before submission. 
>
In my experience, checkpatch ignores long lines that are due to error
messages. Perhaps you need to put the error message on a separate line,
if other things before the message are of significant size.

/Bruce