From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] devtools: add long lines to the list of
 options
Date: Wed, 1 Mar 2017 10:08:51 -0800
Message-ID: <20170301100851.60c3e46c@xeon-e3>
References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <dev@dpdk.org>
To: Allain Legacy <allain.legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41])
 by dpdk.org (Postfix) with ESMTP id CFB9C2B9D
 for <dev@dpdk.org>; Wed,  1 Mar 2017 19:08:53 +0100 (CET)
Received: by mail-pg0-f41.google.com with SMTP id 25so22739416pgy.0
 for <dev@dpdk.org>; Wed, 01 Mar 2017 10:08:53 -0800 (PST)
In-Reply-To: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 1 Mar 2017 12:44:19 -0500
Allain Legacy <allain.legacy@windriver.com> wrote:

> The checkpatch.pl tool is flagging warnings on long debug log strings.
> Since splitting these strings makes it difficult to search for logs it is
> preferred to allow these as exceptions to the long line rule.  The addition
> of the LONG_LINE_STRINGS to the list of exceptions will allow lines that
> end with a string to exceed the maximum line length, but lines that end
> with variables or other constructs will still be flagged as errors.  Also,
> lines that make use of PRIx64 with string concatenation will still be
> flagged if the beginning of the last string fragment begins after the 80
> character threshold.
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
>  devtools/checkpatches.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 78e155e..26ff419 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
>  VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
>  SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING"
>  
>  print_usage () {
>  	cat <<- END_OF_HELP

Maybe it is time to have our own DPDK version of checkpatch which knows about
DPDK API's like logging functions?