From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v1 06/14] ring: remove watermark support
Date: Wed, 1 Mar 2017 10:43:43 +0000
Message-ID: <20170301104343.GC25032@bricha3-MOBL3.ger.corp.intel.com>
References: <20170223172407.27664-1-bruce.richardson@intel.com>
 <20170223172407.27664-7-bruce.richardson@intel.com>
 <20170301113457.0f2a2ef8@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 44F17C304
 for <dev@dpdk.org>; Wed,  1 Mar 2017 11:43:46 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20170301113457.0f2a2ef8@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 01, 2017 at 11:34:57AM +0100, Olivier Matz wrote:
> On Thu, 23 Feb 2017 17:23:59 +0000, Bruce Richardson <bruce.richardson@intel.com> wrote:
> > Remove the watermark support. A future commit will add support for having
> > enqueue functions return the amount of free space in the ring, which will
> > allow applications to implement their own watermark checks, while also
> > being more useful to the app.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  app/test/commands.c                    |  52 ------------
> >  app/test/test_ring.c                   | 149 +--------------------------------
> >  doc/guides/rel_notes/release_17_05.rst |   2 +
> >  examples/Makefile                      |   2 +-
> >  lib/librte_ring/rte_ring.c             |  23 -----
> >  lib/librte_ring/rte_ring.h             |  58 +------------
> >  6 files changed, 8 insertions(+), 278 deletions(-)
> 
> There are some other references to remove:
> 
> app/test/autotest_test_funcs.py:    child.sendline("set_watermark test 100")
> app/test/autotest_test_funcs.py:    index = child.expect(["  watermark=100",
> app/test/autotest_test_funcs.py:        return -1, "Fail [Bad watermark]"
> 
> doc/guides/prog_guide/ring_lib.rst:Water Marking
> doc/guides/prog_guide/ring_lib.rst:The ring can have a high water mark (threshold).
> doc/guides/prog_guide/ring_lib.rst:Once an enqueue operation reaches the high water mark, the producer is notified, if the water mark is configured.
> 
Yep, good catch. Will include in v2

/Bruce