From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v1 06/14] ring: remove watermark support
Date: Wed, 1 Mar 2017 11:34:57 +0100
Message-ID: <20170301113457.0f2a2ef8@platinum>
References: <20170223172407.27664-1-bruce.richardson@intel.com>
 <20170223172407.27664-7-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 448442BB1
 for <dev@dpdk.org>; Wed,  1 Mar 2017 11:35:00 +0100 (CET)
Received: by mail-wr0-f175.google.com with SMTP id l37so26979563wrc.1
 for <dev@dpdk.org>; Wed, 01 Mar 2017 02:35:00 -0800 (PST)
In-Reply-To: <20170223172407.27664-7-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 23 Feb 2017 17:23:59 +0000, Bruce Richardson <bruce.richardson@intel.com> wrote:
> Remove the watermark support. A future commit will add support for having
> enqueue functions return the amount of free space in the ring, which will
> allow applications to implement their own watermark checks, while also
> being more useful to the app.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/test/commands.c                    |  52 ------------
>  app/test/test_ring.c                   | 149 +--------------------------------
>  doc/guides/rel_notes/release_17_05.rst |   2 +
>  examples/Makefile                      |   2 +-
>  lib/librte_ring/rte_ring.c             |  23 -----
>  lib/librte_ring/rte_ring.h             |  58 +------------
>  6 files changed, 8 insertions(+), 278 deletions(-)

There are some other references to remove:

app/test/autotest_test_funcs.py:    child.sendline("set_watermark test 100")
app/test/autotest_test_funcs.py:    index = child.expect(["  watermark=100",
app/test/autotest_test_funcs.py:        return -1, "Fail [Bad watermark]"

doc/guides/prog_guide/ring_lib.rst:Water Marking
doc/guides/prog_guide/ring_lib.rst:The ring can have a high water mark (threshold).
doc/guides/prog_guide/ring_lib.rst:Once an enqueue operation reaches the high water mark, the producer is notified, if the water mark is configured.